fix(Tabs): refactoring nav render function to fix error in production #4787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cat1007
requested review from
PengYYYYY,
chaishi,
xiaosansiji,
honkinglin,
LeeJim and
uyarn
as code owners
|
@PengYYYYY 这个先别合并 |
|
|
uyarn
changed the title
uyarn
approved these changes
Nov 29, 2024
已验证 |
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
#4690
💡 需求背景和解决方案
查看报错，会落到 vue 中的此处代码
因为 nav 渲染中使用到了 ref 特性，但是原实现中，nav 的内容渲染使用了一个 computed 进行实现，比较不合理，重构了相关的渲染函数
📝 更新日志
☑️ 请求合并前的自查清单